Skip to content

a - #2

Merged
deepx4344 merged 1 commit into
mainfrom
dev
Feb 5, 2026
Merged

a#2
deepx4344 merged 1 commit into
mainfrom
dev

Conversation

@deepx4344

Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai

coderabbitai Bot commented Feb 5, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • New Features

    • Load tests now support optional name and description fields for better organization
    • Enhanced validation for load test configuration parameters (URL, method, concurrency, duration, headers)
  • Bug Fixes

    • Improved error handling when test initialization fails—UI state now properly resets
    • Fixed email verification timing in notification flow
  • Security

    • Added authentication requirement to logout endpoint

Walkthrough

The pull request introduces a load testing queue infrastructure by adding bullmq and ioredis dependencies, refactors the service layer to properly create test records, updates data models with enum-based status and method fields, adds validation schemas for load configurations, and enhances route middleware and error handling across authentication and load testing endpoints.

Changes

Cohort / File(s) Summary
Dependencies & Type System
package.json, src/types/index.ts, src/validations/load.ts
Added bullmq and ioredis dependencies; introduced TestStatus and HttpMethods enums; updated ApiResponseinput interface fields; created new loadSchema Joi validation with URL, method, headers, body, concurrency, and duration fields.
Service Layer Refactoring
src/services/loadervice.ts, src/services/loadService.ts
Removed misspelled loadervice.ts file; created corrected loadService.ts with createTest method that persists test documents to the database and returns test IDs.
Email Service Update
src/services/emailService.ts
Reordered sendMail invocation to execute after transporter.verify callback completion rather than immediately after transporter creation.
Data Model & Middleware
src/models/test.ts, src/middlewares/joiValidation.ts
Updated test model to use HttpMethods and TestStatus enums instead of hard-coded arrays; added name and description fields; renamed model export to Tests; removed stripUnknown default from Joi validation options.
Route & Controller Updates
src/routes/load.ts, src/routes/auth.ts, src/controllers/load.ts, src/controllers/auth.ts
Added Joi validation middleware to POST /start load route; added authMiddleware to logout route; fixed loadService import path capitalization; wrapped load response in createAPIResponse with 202 status; added explicit response.end() in auth refresh handler.
Frontend Error Handling
public/src/routes/dashboard/+page.svelte
Enhanced error handling in test start response to set running flag to false and clear polling interval when test\_id is absent from server response.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • Added the frontend and adjusted the backend  #1: Overlaps in frontend dashboard component modifications and backend file changes (test model, loadService, joiValidation middleware), indicating related development work on load testing functionality.

Poem

🐰 Queue and enums, the foundations laid,
With redis and bull, persistence made,
Service layers fixed with rightful names,
Validation and routes, all part of the games,
Test records now flourish in database ground! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'a' is vague and non-descriptive, providing no meaningful information about the changeset. Replace the title with a clear, concise summary of the main change, such as 'Add load testing service with job queue and Redis dependencies'.
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess the intent or details of the changes. Add a pull request description explaining the purpose of these changes and how they integrate load testing functionality.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/types/index.ts (1)

23-31: 🧹 Nitpick | 🔵 Trivial

Confirm ApiResponseinput narrowing is intentional.

data/datas now only allow strings. If any endpoints return objects, this becomes too narrow—consider a generic payload type.

♻️ Proposed refactor
-export interface ApiResponseinput {
+export interface ApiResponseinput<T = unknown> {
   success: boolean;
   message: string;
   token?: string;
   tokens?: Tokens;
   user?: User;
-  data?: string;
-  datas?: string[]
+  data?: T;
+  datas?: T[];
   error?: string;
   errors?: Record<string, string[]>;
 }
🤖 Fix all issues with AI agents
In `@src/controllers/auth.ts`:
- Line 49: The statement using res.status(200).end() is missing a trailing
semicolon causing inconsistency with other similar lines; update the statement
(the res.status(200).end() call in the auth controller) to include a semicolon
at the end to match style of the nearby statements (e.g., those on lines with
res.status(...).end();).

In `@src/routes/load.ts`:
- Line 9: The POST /start route is missing authentication; update the
router.post declaration to include authMiddleware in the middleware chain so
only authenticated users can start load tests—specifically modify the route
using symbols router.post, validateSchema, loadSchema and startLoad to insert
authMiddleware (e.g., include authMiddleware alongside validateSchema before
startLoad) consistent with other protected routes.

In `@src/services/emailService.ts`:
- Around line 25-38: transporter.verify is called with a callback but sendMail
is invoked immediately, causing a race; update the flow in the email sending
function to await verification before sending by promisifying transporter.verify
(or using util.promisify) and calling await verifyPromise() prior to calling
transporter.sendMail, or remove the verify call entirely and handle sendMail
errors—ensure you modify the code around transporter.verify and
transporter.sendMail in src/services/emailService.ts so verification completes
(or is removed) before attempting to send.

In `@src/services/loadService.ts`:
- Around line 7-12: The createTest function currently spreads client-provided
configs into the Tests model allowing override of server-controlled fields like
status and results; fix by whitelisting only intended input fields from configs
(e.g., title, description, params) when constructing the Tests instance and
explicitly set server-controlled fields (status, results, createdBy, etc.) on
the new Tests object before saving; update createTest to use the Tests
constructor with the extracted safe fields and assign status/results values
server-side to prevent client-controlled mutation.

In `@src/validations/load.ts`:
- Around line 4-15: The loadSchema validation currently calls unknown(true)
which allows unexpected client fields (including server-controlled fields like
status/results) to pass through; update loadSchema to reject unknown keys by
replacing unknown(true) with unknown(false) so only the defined properties on
the Joi schema (url, method, name, description, headers, body, concurrency,
duration) are accepted and extraneous fields are rejected before reaching the
MongoDB model.
📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e73814a and 88372c0.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (13)
  • package.json
  • public/src/routes/dashboard/+page.svelte
  • src/controllers/auth.ts
  • src/controllers/load.ts
  • src/middlewares/joiValidation.ts
  • src/models/test.ts
  • src/routes/auth.ts
  • src/routes/load.ts
  • src/services/emailService.ts
  • src/services/loadService.ts
  • src/services/loadervice.ts
  • src/types/index.ts
  • src/validations/load.ts
💤 Files with no reviewable changes (1)
  • src/services/loadervice.ts
🧰 Additional context used
🧬 Code graph analysis (8)
src/routes/auth.ts (1)
src/middlewares/auth.ts (1)
  • req (8-27)
src/controllers/load.ts (1)
src/services/loadervice.ts (1)
  • loadService (3-8)
src/validations/load.ts (1)
src/services/loadervice.ts (1)
  • loadService (3-8)
src/services/loadService.ts (2)
src/types/index.ts (1)
  • configs (44-49)
src/services/loadervice.ts (2)
  • loadService (3-8)
  • configs (4-7)
src/routes/load.ts (2)
src/middlewares/joiValidation.ts (1)
  • validateSchema (7-27)
src/validations/load.ts (1)
  • loadSchema (4-15)
src/services/emailService.ts (2)
src/utils/emailformat.ts (1)
  • payload (7-71)
src/services/authService.ts (2)
  • err (59-61)
  • token (108-114)
src/controllers/auth.ts (1)
src/services/authService.ts (1)
  • token (115-123)
src/types/index.ts (1)
src/models/users.ts (1)
  • usersSchema (3-28)
🔇 Additional comments (7)
src/routes/auth.ts (1)

13-13: Good security improvement: logout now requires authentication.

Adding authMiddleware to the logout route ensures that only authenticated users with valid, non-blacklisted tokens can logout. This prevents potential abuse and aligns with the controller's expectation that req.signedCookies["tokens"] is present.

Minor: consider adding a space after the comma for consistency with line 14.

public/src/routes/dashboard/+page.svelte (1)

51-56: Good defensive fix for error state handling.

Properly resetting running to false and clearing pollInterval when the server fails to return a test ID prevents the UI from getting stuck in a running state. This aligns with the error handling in the catch block below.

src/middlewares/joiValidation.ts (1)

10-10: The concern about unknown fields passing through is unfounded. The registerSchema and loginSchema do not explicitly set .unknown(), so they use Joi's default behavior of .unknown(false), which rejects unknown fields during validation. Unknown fields will not pass through to handlers on these routes—validation will fail and return a 400 error instead.

The loadSchema explicitly sets .unknown(true), allowing unknown fields as intended for that specific route. There is no breaking behavior change affecting existing auth routes.

Likely an incorrect or invalid review comment.

package.json (1)

18-18: These versions are current and secure.

bullmq ^5.67.2 (latest as of Jan 2026, released 2026-01-28) and ioredis ^5.9.2 (latest as of Jan 2026, released 2026-01-15) have no known vulnerabilities. The caret ranges allow appropriate security patch updates.

src/controllers/load.ts (1)

1-16: LGTM: controller now returns structured 202 response.

The response wrapper and testId payload look consistent with the updated flow.

src/types/index.ts (1)

51-64: Enums for TestStatus/HttpMethods look consistent.

src/models/test.ts (1)

38-42: Remove this comment—the concern is based on incorrect assumptions.

The TestStatus enum has always used uppercase values (PENDING, RUNNING, COMPLETED, FAILED) from inception; there is no existing lowercase data to migrate. Additionally, the frontend polling code at public/src/routes/dashboard/+page.svelte will fail because:

  1. No GET endpoint exists to fetch test status (only POST /start is defined in src/routes/load.ts)
  2. The frontend checks res.status === 'completed' (lowercase) but the backend would return uppercase "COMPLETED"

The schema change itself is correct. The real issues to address are adding a GET endpoint to retrieve test status and fixing the frontend-backend status value mismatch.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Comment thread src/controllers/auth.ts
const newToken: string = await auth.refresh(tokens.refreshToken);
tokens.accessToken = newToken;
res.cookie("tokens", tokens, cookieOptions);
res.status(200).end()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Missing semicolon for consistency.

Line 49 is missing a semicolon, while similar statements in this file (lines 33, 41) include one.

🔧 Proposed fix
-  res.status(200).end()
+  res.status(200).end();
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
res.status(200).end()
res.status(200).end();
🤖 Prompt for AI Agents
In `@src/controllers/auth.ts` at line 49, The statement using
res.status(200).end() is missing a trailing semicolon causing inconsistency with
other similar lines; update the statement (the res.status(200).end() call in the
auth controller) to include a semicolon at the end to match style of the nearby
statements (e.g., those on lines with res.status(...).end();).

Comment thread src/routes/load.ts
const router: Router = express.Router();

router.post("/start", startLoad);
router.post("/start", validateSchema(loadSchema), startLoad);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Missing authentication middleware on load testing endpoint.

The /start endpoint allows initiating load tests without authentication. This is a security risk—unauthenticated users could abuse this to launch load tests against arbitrary targets.

Add authMiddleware similar to other protected routes:

🔒 Proposed fix
+import authMiddleware from "../middlewares/auth.js";
+
 const router: Router = express.Router();
 
-router.post("/start", validateSchema(loadSchema), startLoad);
+router.post("/start", authMiddleware, validateSchema(loadSchema), startLoad);
🤖 Prompt for AI Agents
In `@src/routes/load.ts` at line 9, The POST /start route is missing
authentication; update the router.post declaration to include authMiddleware in
the middleware chain so only authenticated users can start load
tests—specifically modify the route using symbols router.post, validateSchema,
loadSchema and startLoad to insert authMiddleware (e.g., include authMiddleware
alongside validateSchema before startLoad) consistent with other protected
routes.

Comment on lines 25 to +38
transporter.verify(function (error, success) {
if (error) {
logger.error(`Connection Error: `,error);
} else {
logger.info("Server is ready to send messages.");
}
});
await transporter.sendMail({
from: `verify@${processConfig.name}.com`,
to: to,
subject: "Verify Your Email",
html: format?.html,
text: format?.text,
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Race condition: sendMail executes before verify callback completes.

transporter.verify() is asynchronous with a callback, but sendMail() is called immediately without waiting for verification to complete. This means emails are sent regardless of whether the transporter is properly configured.

Either remove the verify call (since it provides no protection), or promisify it and await before sending:

🔧 Proposed fix: promisify verify or remove it

Option 1: Remove verify (simpler, rely on sendMail errors)

     });
-    transporter.verify(function (error, success) {
-      if (error) {
-        logger.error(`Connection Error: `,error);
-      } else {
-        logger.info("Server is ready to send messages.");
-      }
-    });
     await transporter.sendMail({

Option 2: Await verify before sending

     });
-    transporter.verify(function (error, success) {
-      if (error) {
-        logger.error(`Connection Error: `,error);
-      } else {
-        logger.info("Server is ready to send messages.");
-      }
-    });
+    await transporter.verify().catch((error) => {
+      logger.error(`Connection Error: `, error);
+      throw error;
+    });
+    logger.info("Server is ready to send messages.");
     await transporter.sendMail({
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
transporter.verify(function (error, success) {
if (error) {
logger.error(`Connection Error: `,error);
} else {
logger.info("Server is ready to send messages.");
}
});
await transporter.sendMail({
from: `verify@${processConfig.name}.com`,
to: to,
subject: "Verify Your Email",
html: format?.html,
text: format?.text,
});
await transporter.sendMail({
from: `verify@${processConfig.name}.com`,
to: to,
subject: "Verify Your Email",
html: format?.html,
text: format?.text,
});
🤖 Prompt for AI Agents
In `@src/services/emailService.ts` around lines 25 - 38, transporter.verify is
called with a callback but sendMail is invoked immediately, causing a race;
update the flow in the email sending function to await verification before
sending by promisifying transporter.verify (or using util.promisify) and calling
await verifyPromise() prior to calling transporter.sendMail, or remove the
verify call entirely and handle sendMail errors—ensure you modify the code
around transporter.verify and transporter.sendMail in
src/services/emailService.ts so verification completes (or is removed) before
attempting to send.

Comment on lines +7 to +12
createTest = async (configs: any): Promise<string> => {
const test = new Tests({
...configs
});
const savedTests = await test.save()
return savedTests._id.toString();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

find . -type f -name "loadService.ts" | head -20

Repository: deepx4344/SurgeTest

Length of output: 92


🏁 Script executed:

find . -type f -name "*[Tt]est*.ts" -o -name "*[Tt]est*.js" | grep -E "(model|schema)" | head -20

Repository: deepx4344/SurgeTest

Length of output: 83


🏁 Script executed:

git ls-files | grep -i test | head -20

Repository: deepx4344/SurgeTest

Length of output: 100


🏁 Script executed:

cat -n src/services/loadService.ts

Repository: deepx4344/SurgeTest

Length of output: 529


🏁 Script executed:

cat -n src/models/test.ts

Repository: deepx4344/SurgeTest

Length of output: 1620


🏁 Script executed:

rg "createTest" --type ts --type js -B 2 -A 2

Repository: deepx4344/SurgeTest

Length of output: 645


🏁 Script executed:

rg "new loadService|loadService\(" --type ts --type js -B 2 -A 2

Repository: deepx4344/SurgeTest

Length of output: 331


🏁 Script executed:

fd "route" --type ts --type js | head -10

Repository: deepx4344/SurgeTest

Length of output: 232


🏁 Script executed:

cat -n src/controllers/load.ts

Repository: deepx4344/SurgeTest

Length of output: 743


🏁 Script executed:

rg "validate|schema|joi|zod" --type-add="ts:*.ts" -i | head -20

Repository: deepx4344/SurgeTest

Length of output: 1383


Whitelist persisted fields to prevent client-controlled status/results.

Spreading configs directly into the Mongoose model allows clients to override server-controlled fields like status and results. Extract only the intended fields from the input.

🛡️ Proposed fix
-  createTest = async (configs: any): Promise<string> => {
-    const test = new Tests({
-      ...configs
-    });
+  createTest = async (configs: any): Promise<string> => {
+    const {
+      url,
+      method,
+      name,
+      description,
+      headers,
+      body,
+      concurrency,
+      duration,
+    } = configs;
+    const test = new Tests({
+      url,
+      method,
+      name,
+      description,
+      headers,
+      body,
+      concurrency,
+      duration,
+    });
🤖 Prompt for AI Agents
In `@src/services/loadService.ts` around lines 7 - 12, The createTest function
currently spreads client-provided configs into the Tests model allowing override
of server-controlled fields like status and results; fix by whitelisting only
intended input fields from configs (e.g., title, description, params) when
constructing the Tests instance and explicitly set server-controlled fields
(status, results, createdBy, etc.) on the new Tests object before saving; update
createTest to use the Tests constructor with the extracted safe fields and
assign status/results values server-side to prevent client-controlled mutation.

Comment thread src/validations/load.ts
Comment on lines +4 to +15
export const loadSchema = Joi.object({
url: Joi.string().required(),
method: Joi.string()
.valid(...Object.values(HttpMethods))
.required(),
name: Joi.string().max(30).allow(""),
description: Joi.string().max(255).allow(""),
headers: Joi.any(),
body: Joi.any(),
concurrency: Joi.number().min(1).default(10),
duration: Joi.number().min(1).default(30),
}).unknown(true);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# First, let's see the full context of the file
head -30 src/validations/load.ts

Repository: deepx4344/SurgeTest

Length of output: 528


🏁 Script executed:

# Search for where loadSchema is used
rg "loadSchema" --type ts

Repository: deepx4344/SurgeTest

Length of output: 278


🏁 Script executed:

# Check other Joi schemas in the codebase for comparison
rg "Joi\.object" --type ts -A 5 | head -100

Repository: deepx4344/SurgeTest

Length of output: 1164


🏁 Script executed:

# Check if there's a pattern of using .unknown() in other schemas
rg "\.unknown\(" --type ts

Repository: deepx4344/SurgeTest

Length of output: 104


🏁 Script executed:

# Check the validateSchema middleware to understand how it processes the schema
rg "validateSchema" --type ts -B 5 -A 10

Repository: deepx4344/SurgeTest

Length of output: 2800


🏁 Script executed:

# Check the startLoad handler to see what it does with the payload
rg "startLoad" --type ts -B 3 -A 15

Repository: deepx4344/SurgeTest

Length of output: 1283


🏁 Script executed:

# Check if there are any comments or documentation about why unknown(true) is used
rg "unknown" --type ts -B 2 -A 2

Repository: deepx4344/SurgeTest

Length of output: 1927


🏁 Script executed:

# Get the full validateSchema middleware implementation
cat -n src/middlewares/joiValidation.ts

Repository: deepx4344/SurgeTest

Length of output: 1147


🏁 Script executed:

# Check what load.createTest does with the config
rg "createTest" --type ts -B 2 -A 15

Repository: deepx4344/SurgeTest

Length of output: 1208


🏁 Script executed:

# Check the loadService to understand the full flow
fd "loadService" --type ts

Repository: deepx4344/SurgeTest

Length of output: 232


🏁 Script executed:

# Find the Tests model to see if it has schema validation
rg "Tests" --type ts | grep -E "(schema|model|interface)" | head -20

Repository: deepx4344/SurgeTest

Length of output: 239


🏁 Script executed:

# Look for the database model definition
fd "test" --type ts | grep -i model

Repository: deepx4344/SurgeTest

Length of output: 232


🏁 Script executed:

# Search for MongoDB model definitions
rg "new Schema\|mongoose.Schema" --type ts -B 2 -A 5

Repository: deepx4344/SurgeTest

Length of output: 45


🏁 Script executed:

# Check what the Tests model looks like
rg "Tests" --type ts -B 3 -A 10 | grep -A 15 "export\|class\|new"

Repository: deepx4344/SurgeTest

Length of output: 1419


🏁 Script executed:

# Get the full test.ts model definition
cat -n src/models/test.ts

Repository: deepx4344/SurgeTest

Length of output: 1620


Reject unknown keys in load payloads.

unknown(true) permits clients to send unexpected fields that reach the MongoDB model, including server-controlled fields like status and results. This bypasses intended field restrictions. Change to unknown(false) to enforce strict validation.

🔒 Proposed fix
-}).unknown(true);
+}).unknown(false);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
export const loadSchema = Joi.object({
url: Joi.string().required(),
method: Joi.string()
.valid(...Object.values(HttpMethods))
.required(),
name: Joi.string().max(30).allow(""),
description: Joi.string().max(255).allow(""),
headers: Joi.any(),
body: Joi.any(),
concurrency: Joi.number().min(1).default(10),
duration: Joi.number().min(1).default(30),
}).unknown(true);
export const loadSchema = Joi.object({
url: Joi.string().required(),
method: Joi.string()
.valid(...Object.values(HttpMethods))
.required(),
name: Joi.string().max(30).allow(""),
description: Joi.string().max(255).allow(""),
headers: Joi.any(),
body: Joi.any(),
concurrency: Joi.number().min(1).default(10),
duration: Joi.number().min(1).default(30),
}).unknown(false);
🤖 Prompt for AI Agents
In `@src/validations/load.ts` around lines 4 - 15, The loadSchema validation
currently calls unknown(true) which allows unexpected client fields (including
server-controlled fields like status/results) to pass through; update loadSchema
to reject unknown keys by replacing unknown(true) with unknown(false) so only
the defined properties on the Joi schema (url, method, name, description,
headers, body, concurrency, duration) are accepted and extraneous fields are
rejected before reaching the MongoDB model.

@deepx4344
deepx4344 merged commit b2bff96 into main Feb 5, 2026
1 check passed
@coderabbitai coderabbitai Bot mentioned this pull request Feb 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant